[dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function name of tunnel port config

Lu, Wenzhuo wenzhuo.lu at intel.com
Wed Mar 9 03:30:19 CET 2016


Hi Thomas,

> > > >
> > > > You must move it below the doxygen comment.
> > > OK. Honestly, I'd like to act like that. But seems the style is to
> > > put the function above the comment.(Don't know the reason.)
> >
> > Do you mean the function below the comment?
> No, I really mean above. Like this,
> typedef int (*eth_get_reg_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_reg_info *info);
> /**< @internal Retrieve registers  */
> 
> typedef int (*eth_get_eeprom_length_t)(struct rte_eth_dev *dev); /**<
> @internal Retrieve eeprom size  */
> 
> typedef int (*eth_get_eeprom_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_eeprom_info *info);
> /**< @internal Retrieve eeprom data  */
> 
> typedef int (*eth_set_eeprom_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_eeprom_info *info);
> /**< @internal Program eeprom data  */
Sorry, I misunderstood you. I'll do what you suggested.



More information about the dev mailing list