[dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions

Trahe, Fiona fiona.trahe at intel.com
Thu Mar 10 11:30:00 CET 2016


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, March 08, 2016 2:11 PM
> To: Trahe, Fiona
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to
> support future extensions
> 
> Hi,
> 
> 2016-03-07 11:50, Fiona Trahe:
> > This patch splits symmetric specific definitions and  functions away
> > from the common crypto APIs to facilitate the future extension  and
> > expansion of the cryptodev framework, in order to allow  asymmetric
> > crypto operations to be introduced at a later date, as well as to
> > clean the  logical structure of the public includes. The patch also
> > introduces the _sym  prefix to symmetric specific structure and
> > functions to improve clarity in  the API.
> 
> It seems you need to update the examples in the same patch, they do not
> compile anymore after these changes.
Sorry, fixed.

> Again, it would be easier to review if you had split the changes to several
> patches: one for the sym suffix, others for more tidying.
V8 patchset will be sent shortly with more granular split


More information about the dev mailing list