[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

Bruce Richardson bruce.richardson at intel.com
Thu Mar 10 11:33:27 CET 2016


On Fri, Mar 04, 2016 at 10:28:44PM +0000, Rasesh Mody wrote:
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chas Williams
> > Sent: Wednesday, December 30, 2015 4:38 PM
> > 
> > From: "Charles (Chas) Williams" <ciwillia at brocade.com>
> > 
> > bnx2x_loop_obtain_resources() returns a struct containing the status and
> > the error message.  If bnx2x_do_req4pf() fails, it shouldn't return both of
> > these fields set to 0 indicating failure and no error.
> > 
> > Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
> > so that bnx2x_loop_obtain_resources() can negotiate reduced resource
> > requirments.  This requires additional checking around bnx2x_do_req4pf().
> > 
> > Signed-off-by: Chas Williams <3chas3 at gmail.com>
> > ---
> 
> Acked-by: Rasesh Mody <rasesh.mody at qlogic.com>
> 
> The change looks good.
> 
> Thanks!
> Rasesh
> 

Applied to dpdk-next-net/rel_16_04, with added fixes line in message.

/Bruce



More information about the dev mailing list