[dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled

Panu Matilainen pmatilai at redhat.com
Fri Mar 11 10:38:58 CET 2016


On 03/11/2016 11:28 AM, Thomas Monjalon wrote:
> 2016-03-11 11:13, Panu Matilainen:
>> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
>> build of any crypto pmds will fail because of the missing dependency.
>> This has been present for a while now but hidden until the addition
>> of null_crypto since all the other crypto pmds have been disabled
>> by default.
>
> Good catch, thanks.
>
>> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>>  DIRS-y += crypto
>> +endif
>
> Why not
> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?

Just because old habits ... and ... you know :)

Should I send a new version or can you fix that up when committing?

	- Panu -


More information about the dev mailing list