[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

Stephen Hemminger stephen at networkplumber.org
Wed Mar 30 18:40:29 CEST 2016


On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody at qlogic.com> wrote:

> +static void
> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev,
> +		     __rte_unused uint32_t index)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +
> +	/* TBD: Not implemented currently because DPDK does not provide
> +	 * macaddr and instead just passes the index. So pmd needs to
> +	 * maintain index mapping to macaddr.
> +	 */
> +	DP_NOTICE(edev, false, "%s: Unsupported operation\n", __func__);
> +}
> +

Rather than have a stub and break software, why not just
not define the operation and let base DPDK handle the error?


More information about the dev mailing list