[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

[Jan Viktorin]

On Fri, 06 May 2016 16:01:08 +0200
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:

> 2016-05-06 12:48, Jan Viktorin:
> > --- /dev/null
> > +++ b/app/test/resource.h
> > @@ -0,0 +1,61 @@
> > +/*-
> > + *   BSD LICENSE  
> [...]
> > + */  
> 
> Please include a multi-line comment here to explain what is a resource
> and why it is needed.
> 
> > +
> > +#ifndef _RESOURCE_H_
> > +#define _RESOURCE_H_
> > +  
> |...]
> |> +
> > +TAILQ_HEAD(resource_list, resource);
> > +extern struct resource_list resource_list;  
> 
> Why extern?

It is not a definition. There is a single global resource_list and
it is defined in the resource.c. A common practice in DPDK (eg. rte_pci.h).
Do I miss something?

Regards
Jan

> 

[...]


-- 
   Jan Viktorin                  E-mail: Viktorin at RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic