[dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from xstats
Tahhan, Maryam
maryam.tahhan at intel.com
Mon May 16 12:42:42 CEST 2016
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, May 6, 2016 12:11 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from
> xstats
>
> The current extended ethernet statistics fetching involve doing several
> string operations, which causes performance issues if there are lots of
> statistics and/or network interfaces. This RFC patchset changes the API
> for xstats to use integer identifiers instead of strings and implements this
> new API for the ixgbe driver. Others drivers to follow.
>
> --
>
> v2 changes:
> * Fetching xstats count now seperate API function
> * Added #define constants for some magic numbers
> * Fixed bug with virtual function count fetching
> * For non-xstats-supporting drivers, queue stats returned
> * Some refactoring/cleanups
> * Removed index assumption from example
>
>
> Remy Horton (3):
> rte: change xstats to use integer keys
> drivers/net/ixgbe: change xstats to use integer keys
> examples/ethtool: add xstats display command
>
> drivers/net/ixgbe/ixgbe_ethdev.c | 98
> ++++++++++++++++++++++++++++-----
> examples/ethtool/ethtool-app/ethapp.c | 57 +++++++++++++++++++
> lib/librte_ether/rte_ethdev.c | 100
> +++++++++++++++++++++++++++++-----
> lib/librte_ether/rte_ethdev.h | 55 +++++++++++++++++++
> 4 files changed, 284 insertions(+), 26 deletions(-)
>
> --
> 2.5.5
Looks Great overall. Is there a need to update prog_guide/poll_mode_drv.rst with the new mods?
BR
Maryam
More information about the dev
mailing list