[dpdk-dev] [PATCH v2 26/40] bnxt: add HWRM stat context free function

Bruce Richardson bruce.richardson at intel.com
Thu May 26 15:15:57 CEST 2016


On Fri, May 13, 2016 at 03:46:15PM -0700, Stephen Hurd wrote:
> Add function and associated structures and definitions as well as
> some convenienct functions for manipulating the state of the entire
> function.
> 
Again, I think more explanation is needed in the commit message. The commit
title refers to freeing stat contexts, but the patch itself contains functions
working on filters. Either the filter functions belong in a different patch,
or we need more explanation as to why they would belong in this one.

I'd also question if the ordering of the patches should be changed. In other
cases you have a single patch adding allocation and free functions together, but
for these stats contexts there are two patches which are separated in the series.
Logically, if they are not merged, it would be good if they could be at least
sequential commits.

Thanks,
/Bruce



More information about the dev mailing list