[dpdk-dev] [PATCH v3 31/40] bnxt: add start/stop/link update operations

Bruce Richardson bruce.richardson at intel.com
Thu May 26 15:46:11 CEST 2016


On Wed, May 18, 2016 at 01:29:41PM -0700, Stephen Hurd wrote:
> BNXT driver will now minimally pass traffic with testpmd.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 267 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 267 insertions(+)
>
<snip>
> +	memset(&new, 0, sizeof(new));
> +	do {
> +		/* Retrieve link info from hardware */
> +		rc = bnxt_get_hwrm_link_config(bp, &new);
> +		if (rc) {
> +			new.link_speed = ETH_LINK_SPEED_100M;
> +			new.link_duplex = ETH_LINK_FULL_DUPLEX;
> +			RTE_LOG(ERR, PMD,
> +				"Failed to retrieve link rc = 0x%d!", rc);

Checkpatch correctly flags this as an error. If you put 0x in front of a number
the output format needs to be %x rather than %d.

/Bruce



More information about the dev mailing list