[dpdk-dev] [PATCH v2 40/40] bnxt: cleanup null pointer checks

Bruce Richardson bruce.richardson at intel.com
Thu May 26 17:20:43 CEST 2016


On Fri, May 13, 2016 at 03:46:29PM -0700, Stephen Hurd wrote:
> Prefer !ptr to ptr == NULL
> 
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>

Nak to this particular patch, as it contradicts DPDK coding guidelines which is
to make NULL checks explicit. Ref [1]

/Bruce

[1] http://dpdk.org/doc/guides/contributing/coding_style.html#c-statement-style-and-conventions



More information about the dev mailing list