[dpdk-dev] [PATCH] net/mlx5: fix handling of small mbuf sizes

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Nov 7 18:22:59 CET 2016


2016-10-28 14:19, Adrien Mazarguil:
> On Mon, Oct 24, 2016 at 11:10:59AM +0300, Raslan Darawsheh wrote:
> > When mbufs are smaller than MRU, multi-segment support must be enabled to
> > default set when not in promiscuous or allmulticast modes.
> > 
> > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support")
> > 
> > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
[...]
> > +	/* If smaller than MRU, multi-segment support must be enabled. */
> > +	if (mb_len < (priv->mtu > dev->data->dev_conf.rxmode.max_rx_pkt_len ?
> > +		     dev->data->dev_conf.rxmode.max_rx_pkt_len :
> > +		     priv->mtu
> > +		     ))
> 
> Let's move poor "))" to the end of the previous line.
[...]
> Besides the above comment:
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>

Fixed and applied, thanks


More information about the dev mailing list