[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization
Thomas Monjalon
thomas.monjalon at 6wind.com
Mon Oct 3 16:28:01 CEST 2016
Applied, thanks everybody for the great (re)work!
2016-09-20 18:11, Shreyansh Jain:
> Future Work/Pending:
> ===================
> - Presently eth_driver, rte_eth_dev are not aligned to the rte_driver/
> rte_device model. eth_driver still is a PCI specific entity. This
> has been highlighted by comments from Ferruh in [9].
> - Some variables, like drv_name (as highlighted by Ferruh), are getting
> duplicated across rte_xxx_driver/device and rte_driver/device.
What about those pending work?
I would add more remaining issues:
- probe/remove naming could be applied to vdev for consistency
- rte_eal_device_insert must be called in vdev
- REGISTER macros should be prefixed with RTE_
- Some functions in EAL does not need eal_ in their prefix:
rte_eal_pci_ -> rte_pci_
rte_eal_dev_ -> rte_dev_
rte_eal_vdev_ -> rte_vdev_
rte_eal_driver -> rte_drv_
rte_eal_vdrv -> rte_vdrv_
More information about the dev
mailing list