[dpdk-dev] [PATCH v2 4/8] app/testpmd: add option to enable lro

[Olivier Matz]

Hi Pablo,

On 10/05/2016 08:26 AM, De Lara Guarch, Pablo wrote:
> Hi Olivier,
> 
>> -----Original Message-----
>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>> Sent: Friday, September 09, 2016 12:56 AM
>> To: dev at dpdk.org; De Lara Guarch, Pablo
>> Subject: [PATCH v2 4/8] app/testpmd: add option to enable lro
>>
>> Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO
>> feature on enabled ports, like it's done for '--enable-rx-cksum' for
>> instance.
>>
>> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>> ---
>>  app/test-pmd/parameters.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index 8792c2c..612ad37 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -150,6 +150,7 @@ usage(char* progname)
>>  	       "If the drop-queue doesn't exist, the packet is dropped. "
>>  	       "By default drop-queue=127.\n");
>>  	printf("  --crc-strip: enable CRC stripping by hardware.\n");
>> +	printf("  --enable-lro: enable large receive offload.\n");
>>  	printf("  --enable-rx-cksum: enable rx hardware checksum
>> offload.\n");
>>  	printf("  --disable-hw-vlan: disable hardware vlan.\n");
>>  	printf("  --disable-hw-vlan-filter: disable hardware vlan filter.\n");
>> @@ -525,6 +526,7 @@ launch_args_parse(int argc, char** argv)
>>  		{ "pkt-filter-size",            1, 0, 0 },
>>  		{ "pkt-filter-drop-queue",      1, 0, 0 },
>>  		{ "crc-strip",                  0, 0, 0 },
>> +		{ "enable-lro",                 0, 0, 0 },
>>  		{ "enable-rx-cksum",            0, 0, 0 },
>>  		{ "enable-scatter",             0, 0, 0 },
>>  		{ "disable-hw-vlan",            0, 0, 0 },
>> @@ -765,6 +767,8 @@ launch_args_parse(int argc, char** argv)
>>  			}
>>  			if (!strcmp(lgopts[opt_idx].name, "crc-strip"))
>>  				rx_mode.hw_strip_crc = 1;
>> +			if (!strcmp(lgopts[opt_idx].name, "enable-lro"))
>> +				rx_mode.enable_lro = 1;
>>  			if (!strcmp(lgopts[opt_idx].name, "enable-scatter"))
>>  				rx_mode.enable_scatter = 1;
>>  			if (!strcmp(lgopts[opt_idx].name, "enable-rx-cksum"))
>> --
>> 2.8.1
> 
> Could you add this new parameter in the testpmd documentation?

Yes, I'll do it.


Thanks,
Olivier