[dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD

[Shreyansh Jain]

On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote:
> 2016-10-09 15:12, Shreyansh Jain:
>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>> 2016-10-08 23:35, Shreyansh Jain:
>>>> +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\.
>>> ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\
>>>> +       then \
>>>
>>> I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ?
>>
>> Because I want to make sure that the grep matches only the DRIVER registration functions.
>> In case a new macro (or driver type) is added in future, this macro can be updated. This way we can reduce the probability of a faulty match.
>>
>> Is there a problem with closest possible match?
>
> It is just long and useless. A macro starting with RTE_PMD_REGISTER_ must
> be called from a PMD. What else?

Long, yes. But I don't know why you state it as useless. Reducing 
probability of a false positive is what it does.

Anyways, I will send a v3 with "grep -Eq 'DRIVER_REGISTER_.*\(.*\)'".

-
Shreyansh