[dpdk-dev] [PATCH v2 06/12] app/testpmd: fix checksum stats in csum engine

[Maxime Coquelin]

On 10/03/2016 11:00 AM, Olivier Matz wrote:
> ---
>  app/test-pmd/csumonly.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index d5eb260..8c88ee8 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -679,8 +679,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>  		rx_ol_flags = m->ol_flags;
>
>  		/* Update the L3/L4 checksum error packet statistics */
> -		rx_bad_ip_csum += ((rx_ol_flags & PKT_RX_IP_CKSUM_BAD) != 0);
> -		rx_bad_l4_csum += ((rx_ol_flags & PKT_RX_L4_CKSUM_BAD) != 0);
> +		if ((rx_ol_flags & PKT_RX_IP_CKSUM_MASK) == PKT_RX_IP_CKSUM_BAD)
> +			rx_bad_ip_csum += 1;
> +		if ((rx_ol_flags & PKT_RX_L4_CKSUM_MASK) == PKT_RX_L4_CKSUM_BAD)
> +			rx_bad_l4_csum += 1;
>
>  		/* step 1: dissect packet, parsing optional vlan, ip4/ip6, vxlan
>  		 * and inner headers */
>

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime