[dpdk-dev] [PATCH v5] drivers/net:new PMD using tun/tap host interface

[Wiles, Keith]

Regards,
Keith

> On Oct 12, 2016, at 1:19 PM, Wiles, Keith <keith.wiles at intel.com> wrote:
> 
> 
> Regards,
> Keith
> 
>> On Oct 12, 2016, at 9:56 AM, Yigit, Ferruh <ferruh.yigit at intel.com> wrote:
>> 
>>> +
>>> +static void
>>> +tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)
>>> +{
>>> +	unsigned i, imax;
>> 
>> checkpatch complain about not using "unsigned int”
> 
> I ran checkpatch on the patch and saw no errors reported via the scripts/checkpatch.sh. Which checkpatch are you using here?

OK, the scripts/checkpatch.sh does not seem to report any failures, but running checkpatch.pl does report problems. Is the scripts/checkpatch.sh script suppose to display the errors or what?

It seems odd for the script file not to display warnings and errors, unless it is just for validating patch. I would expect the script show the problems normally or at least with an option.