[dpdk-dev] [PATCH] testpmd: fix tso with csum engine

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Oct 13 16:01:37 CEST 2016


2016-10-13 15:40, Olivier Matz:
> The commit that disabled tso for small packets was broken during the
> rebase. The problem is the IP checksum is not calculated in software if:
> - TX IP checksum is disabled
> - TSO is enabled
> - the current packet is smaller than tso segment size
> 
> When checking if the PKT_TX_IP_CKSUM flag should be set (in case
> of tso), use the local tso_segsz variable, which is set to 0 when the
> packet is too small to require tso. Therefore the IP checksum will be
> correctly calculated in software.
> 
> Moreover, we should not use tunnel segment size for non-tunnel tso, else
> TSO will stay disabled for all packets.
> 
> Fixes: 97c21329d42b ("app/testpmd: do not use TSO for small packets")
> 
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>

Applied, thanks


More information about the dev mailing list