[dpdk-dev] [PATCH] net/qede: fix advertising link speed capability

Harish Patil harish.patil at qlogic.com
Sat Oct 29 03:11:33 CEST 2016


>2016-10-27 23:42, Rasesh Mody:
>> From: Harish Patil <harish.patil at qlogic.com>
>> 
>> Fix to advertise device's link speed capability based on current
>> link speed rather than returning driver supported speeds.
>[...]
>> -	dev_info->speed_capa = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G |
>> -			       ETH_LINK_SPEED_100G;
>> +	memset(&link, 0, sizeof(struct qed_link_output));
>> +	qdev->ops->common->get_link(edev, &link);
>> +	dev_info->speed_capa = rte_eth_speed_bitflag(link.speed, 0);
>>  }
>
>No, that's wrong.
>You must advertise a capability!
Got it. It was not very clear to me. Let me send out v2 patch that would
advertise native link speed based on the NIC personality configured (and
not based on current/negotiated link speed).

>So what the device supports?
10, 25, 40, 50, 100G speeds
>Are every qede devices support ETH_LINK_SPEED_100G?
No



More information about the dev mailing list