[dpdk-dev] [PATCH] virtio: remove obsolete comment

Matthias Gatto matthias.gatto at outscale.com
Fri Sep 2 17:05:21 CEST 2016


As new_device and destroy_device use an int instead of a "struct virtio_net *",
The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
If I've correctly understand the code, the drivers take care of
setting the flag before calling the callbacks, so I guess that this comment
is obsolet and I've remove it.

Signed-off-by: Matthias Gatto <matthias.gatto at outscale.com>
---
 lib/librte_vhost/rte_virtio_net.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h
index 9caa622..a88aecd 100644
--- a/lib/librte_vhost/rte_virtio_net.h
+++ b/lib/librte_vhost/rte_virtio_net.h
@@ -59,10 +59,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
 
 /**
  * Device and vring operations.
- *
- * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and
- * remove it in destroy_device.
- *
  */
 struct virtio_net_device_ops {
 	int (*new_device)(int vid);		/**< Add device. */
-- 
2.9.3



More information about the dev mailing list