[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

Ferruh Yigit ferruh.yigit at intel.com
Tue Sep 13 19:15:43 CEST 2016


On 9/13/2016 6:10 PM, Ferruh Yigit wrote:
> Hi Alejandro,
> 
> On 8/16/2016 4:15 PM, Alejandro Lucero wrote:
>> Signed-off-by: Alejandro Lucero <alejandro.lucero at netronome.com>
>> ---
> 
> There are following checkpatch warnings, also check-git-log complains:
> 
> Headline too long:
>         nfp: unregister interrupt callback function when closing device
> 

copy-paste error, this one gives following, again because of "mac" usage:

Wrong headline lowercase:
        nfp: using random mac address if not a configured mac


> ...
> 
>>  
>> +static void nfp_net_read_mac(struct nfp_net_hw *hw) {
>> +
> 
> ERROR:OPEN_BRACE: open brace '{' following function declarations go on
> the next line
> #45: FILE: drivers/net/nfp/nfp_net.c:620:
> +static void nfp_net_read_mac(struct nfp_net_hw *hw) {
> 
> ...
> 
>> +	if (!is_valid_assigned_ether_addr((struct ether_addr *)&hw->mac_addr[0]))
> 
> WARNING:LONG_LINE: line over 80 characters
> #67: FILE: drivers/net/nfp/nfp_net.c:2419:
> +       if (!is_valid_assigned_ether_addr((struct ether_addr
> *)&hw->mac_addr[0]))
> 
>> +		/* Using random mac addresses for VFs */
> 



More information about the dev mailing list