[dpdk-dev] [PATCH] pci: fix one device probing

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Sep 16 15:20:04 CEST 2016


2016-08-04 14:50, Igor Ryzhov:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
> 
> Signed-off-by: Igor Ryzhov <iryzhov at nfware.com>
[...]
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
>  			continue;
>  
>  		ret = pci_probe_all_drivers(dev);
> -		if (ret < 0)
> +		if (ret)
>  			goto err_return;
>  		return 0;
>  	}

This patch was discussed in another thread:
	http://dpdk.org/ml/archives/dev/2016-August/045127.html
Is there anyone thinking this patch is not a step forward?


More information about the dev mailing list