[dpdk-dev] [PATCH] hash: Correctly set the compare function.

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Sep 22 17:42:55 CEST 2016


2016-09-19 18:36, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Masoud
> Commit titles start with lowercase ("correctly") and without a dot at the end.
> > 
> > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the
> > custom
> > function we are setting in rte_hash_set_cmp_func properly works. The
> > custom
> > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
> > KEY_CUSTOM.
> 
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.

Applied, thanks


More information about the dev mailing list