[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, September 13, 2016 4:10 PM
> To: Loftus, Ciara <ciara.loftus at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the
> 'vid' for a given port id.
> 
> 2016-09-13 14:47, Ciara Loftus:
> > In some cases when using the vHost PMD, certain vHost library
> > functions may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of
> > virtqueues reported by the guest - information which is not exposed by
> the PMD.
> >
> > This commit introduces a new rte_eth_vhost function that returns the
> > 'vid' associated with a given port id. This allows the PMD user to
> > call vHost library functions which require the 'vid' value.
> 
> I think we should not add any API to the PMDs.
> Maybe you are looking for a generic API in ethdev.

Hi,

This patch got a little lost in a general discussion on generic versus specific APIs.

As far as I can see this is a PMD specific API and the general consensus by the end of the thread was that this would be acceptable. Is that the case or are there still objections to this patch.

The patch is critical for integration of the Vhost PMD into OvS so I'd like to make sure that we consider it as such. See the discussion here:

    http://openvswitch.org/pipermail/dev/2016-August/076887.html

John