[dpdk-dev] [PATCH v3 5/5] net/virtio-user: add lsc support

[Yuanhan Liu]

On Fri, Mar 31, 2017 at 07:44:58PM +0000, Jianfeng Tan wrote:
> +static void virtio_user_delayed_handler(void *param)

Coding style issue.

...
>  
>  	if (offset == offsetof(struct virtio_net_config, max_virtqueue_pairs))
>  		*(uint16_t *)dst = dev->max_queue_pairs;
> @@ -319,7 +362,11 @@ virtio_user_eth_dev_alloc(const char *name)
>  
>  	dev->portid = hw->port_id = data->port_id;
>  	virtio_hw_internal[hw->port_id].vtpci_ops = &virtio_user_ops;
> -	hw->use_msix = 0;
> +	/* After commit 26bbd3e7dc51("net/virtio: disable LSC interrupt if MSIX
> +	 * not enabled"), we require this to enable LSC. Just pretend that we
> +	 * support msix.
> +	 */

We normally do not reference a commit in comments. Instead, you could
simply say "this is required to enable LSC (see __the_function__), ...".

Series applied to dpdk-next-virtio, with above minor fixes.

	--yliu

> +	hw->use_msix = 1;
>  	hw->modern   = 0;
>  	hw->use_simple_rxtx = 0;
>  	hw->virtio_user_dev = dev;
> -- 
> 2.7.4