[dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

Ferruh Yigit ferruh.yigit at intel.com
Tue Apr 4 19:20:49 CEST 2017


On 4/4/2017 6:17 PM, Legacy, Allain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
>> Sent: Tuesday, April 04, 2017 1:12 PM
> <...>
>>
>> Right now compiler config files only have compiler and architecture configs,
>> although it is OK to update them, to be consistent with what other PMDs did,
>> what do you think:
>>
>> Keep AVP config enabled in "common_linuxapp"
>>
>> Disable AVP in following configs:
>> defconfig_arm64-armv8a-linuxapp-gcc
>> defconfig_arm-armv7a-linuxapp-gcc
>> defconfig_ppc_64-power8-linuxapp-gcc
> 
> If that is your preference I can update the patch but either way a compiler config file is going to be changed.   
> I did it the current way so that if a new architecture came along that they would not need to know to set AVP=n in their file.

Indeed, this makes sense.

> 
> Do you still want me to align to your suggestion?

I still believe good to be consistent with current usage. They all can
be fixed later, for example when a new architecture added, in one go.

Thanks,
ferruh


More information about the dev mailing list