[dpdk-dev] [PATCH v3] net/i40e: fix return value check issue

[Ferruh Yigit]

On 4/6/2017 9:27 AM, Zhang, Helin wrote:
> Hi Henry
> 
> I don't know why.
> 
> Hi Ferruh
> 
> Do you have any idea on this warning? Does Henry need to fix that?

That is because commit log has a long line, line should be less than
72chars. I can fix it while applying.

Thanks,
ferruh

> 
> Regards,
> Helin
> 
>> -----Original Message-----
>> From: caihe [mailto:caihe at huawei.com]
>> Sent: Thursday, April 6, 2017 3:27 PM
>> To: Zhang, Helin
>> Cc: dev at dpdk.org; Wu, Jingjing; Zhoujingbin
>> Subject: 答复: [PATCH v3] net/i40e: fix return value check issue
>>
>> The warning as below:
>> WARNING: Possible unwrapped commit description (prefer a maximum 75
>> chars per line)
>> #6:
>> function i40evf_add_del_all_mac_addr without check return value of
>> rte_zmalloc
>>
>> total: 0 errors, 1 warnings, 0 checks, 10 lines checked
>>
>> And the waring line content is:
>> +			PMD_DRV_LOG(ERR, "fail to allocate memory");
>>
>> I have no idea how to fix it, and have tried some alternative ways to avoid the
>> warning, but fails with another different warning.
>> I even doubt some configurations is wrong in my local environment, so I post
>> the patch, but fail with the same warning.
>>
>> Could you offer some advice to avoid this warning, else we should avoid this
>> warning with another different patch?
>>
>> Thanks
>> Henry
>>
>> -----邮件原件-----
>> 发件人: Zhang, Helin [mailto:helin.zhang at intel.com]
>> 发送时间: 2017年4月6日 14:35
>> 收件人: caihe
>> 抄送: dev at dpdk.org; Wu, Jingjing; Zhoujingbin
>> 主题: RE: [PATCH v3] net/i40e: fix return value check issue
>>
>>
>>
>>> -----Original Message-----
>>> From: caihe [mailto:caihe at huawei.com]
>>> Sent: Thursday, April 6, 2017 9:06 AM
>>> To: Zhang, Helin
>>> Cc: dev at dpdk.org; Wu, Jingjing; Zhoujingbin
>>> Subject: 答复: [PATCH v3] net/i40e: fix return value check issue
>>>
>>> Do you have any idea to fix the patch check warning, this is already
>>> the perfect way?
>> Basically we use Linux script tool of checkpatch.pl to check the patch before
>> sending it out.
>> But what's the issue you mentioned above? I don't see anything.
>>
>> Thanks,
>> Helin
>>>
>>> -----邮件原件-----
>>> 发件人: Zhang, Helin [mailto:helin.zhang at intel.com]
>>> 发送时间: 2017年4月5日 23:34
>>> 收件人: caihe
>>> 抄送: dev at dpdk.org; Wu, Jingjing; Zhoujingbin
>>> 主题: RE: [PATCH v3] net/i40e: fix return value check issue
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: henry [mailto:caihe at huawei.com]
>>>> Sent: Wednesday, April 5, 2017 9:20 PM
>>>> To: Zhang, Helin
>>>> Cc: dev at dpdk.org; Wu, Jingjing; zhoujingbin at huawei.com; henry cai
>>>> Subject: [PATCH v3] net/i40e: fix return value check issue
>>>>
>>>> From: henry cai <caihe at huawei.com>
>>>>
>>>> function i40evf_add_del_all_mac_addr without check return value of
>>>> rte_zmalloc
>>>>
>>>> Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address ")
>>>>
>>>> Signed-off-by: henry cai <caihe at huawei.com>
>>> Acked-by: Helin Zhang <helin.zhang at intel.com>
>>>> ---
>>>>  drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> index d3659c9..3e0e2e1 100644
>>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> @@ -2016,6 +2016,10 @@ static int i40evf_dev_xstats_get(struct
>>>> rte_eth_dev *dev,
>>>>  		}
>>>>
>>>>  		list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
>>>> +		if (!list) {
>>>> +			PMD_DRV_LOG(ERR, "fail to allocate memory");
>>>> +			return;
>>>> +		}
>>>>
>>>>  		for (i = begin; i < next_begin; i++) {
>>>>  			addr = &dev->data->mac_addrs[i];
>>>> --
>>>> 1.8.3.1
>>>>
>