[dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID

Mcnamara, John john.mcnamara at intel.com
Thu Apr 13 12:52:04 CEST 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Tuesday, April 11, 2017 5:37 PM
> To: dev at dpdk.org
> Cc: Jain, Deepak K <deepak.k.jain at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Piasecki, JacekX
> <jacekx.piasecki at intel.com>; Kozak, KubaX <kubax.kozak at intel.com>;
> Kulasek, TomaszX <tomaszx.kulasek at intel.com>
> Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving
> by ID
> 
> From: Jacek Piasecki <jacekx.piasecki at intel.com>
> 
> ...
>
> +Scheme for Human Readable Names
> +_______________________________
> 
>  A naming scheme exists for the strings exposed to clients of the API.
> This is  to allow scraping of the API for statistics of interest. The
> naming scheme uses @@ -363,8 +359,8 @@ strings split by a single


Minor request, if you are updating this patchset could you use a different
title underline than ____.

The guidelines suggest:

    Level 1 Heading
    ===============


    Level 2 Heading
    ---------------


    Level 3 Heading
    ~~~~~~~~~~~~~~~


    Level 4 Heading
    ^^^^^^^^^^^^^^^

http://dpdk.org/doc/guides/contributing/documentation.html#section-headers


So in this case it should probably be ^^^^^^^^^^.

However, that is fairly minor and it is okay as is if you don't get to it.

John


More information about the dev mailing list