[dpdk-dev] [PATCH] net/avp: fix interrupt migration check

Ferruh Yigit ferruh.yigit at intel.com
Fri Apr 28 08:49:03 CEST 2017


Bitwise OR within if statement is always true, fix bitwise operator.

Coverity issue: 1423906
Fixes: 82e140b84995 ("net/avp: handle interrupt migration")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/avp/avp_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 9ca2786..fe6849f 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -712,7 +712,7 @@ avp_dev_interrupt_handler(void *data)
 		RTE_PTR_ADD(registers,
 			    RTE_AVP_INTERRUPT_STATUS_OFFSET));
 
-	if (status | RTE_AVP_MIGRATION_INTERRUPT_MASK) {
+	if (status & RTE_AVP_MIGRATION_INTERRUPT_MASK) {
 		/* handle interrupt based on current status */
 		value = AVP_READ32(
 			RTE_PTR_ADD(registers,
-- 
2.9.3



More information about the dev mailing list