[dpdk-dev] [PATCH] devargs: fix scan mode configuration in add

[Gaëtan Rivet]

On Wed, Aug 02, 2017 at 04:32:38PM +0200, Thomas Monjalon wrote:
> 02/08/2017 10:55, Gaetan Rivet:
> > When adding rte_devargs to the list, a check is performed on the
> > intended bus that should use this rte_devargs. This bus configuration is
> > for the time being only set once when the first rte_devargs is added to
> > it. If the bus configuration has previously been set, then the rte_devargs
> > insertion fails.
> 
> Sorry, I don't understand which logic is changed :)
> Maybe it would be easier with an example?
> 

Ok, I will send a more explicit v2.

> > Failure occuring upon detection of the set configuration is an API
> > change. While rules will certainly be enforced in the next rte_devargs
> > API, none were previously enforced and this should be respected until
> > this API is deprecated.
> > 
> > The bus configuration is meant to evolve soon, but in the meantime it
> > should strictly follow the current rte_eal_devargs_add API.
> > 
> > The rte_devargs unit tests are failing due to this API change. Revert
> > this evolution, it will be reintroduced properly in the next release if
> > necessary.
> 
> So this is a revert.
> I think the title start with "revert" instead of "fix" as you seem
> to go back to the old behaviour.

This API change introduced by the bus configuration is a bug. It was
meant to prepare the change, not enact it. Reverting to the old behavior
is fixing this mistake.

But revert is fine if you prefer.

-- 
Gaëtan Rivet
6WIND