[dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

[Thomas Monjalon]

03/08/2017 15:58, Gaëtan Rivet:
> Hi Raslan,
> 
> I sent a patch earlier regarding this but we will use yours.
> Two small nits below.
> 
> On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasland at mellanox.com wrote:
> > From: Raslan Darawsheh <rasland at mellanox.com>
> > 
> > When there is no prefered device, failsafe will always
> > try to scan for prefered device. And if there is no device
> > found with the exec option, popen() will get an empty output.
> > In this case, it was forgotten to close the file descriptor.o
> > it is fixed by closing the file descriptor even if the output is emtpy.
> > 
> 
> Good job on finding the issue and fixing it.
> It has been assigned a coverity ID:
> 
> Coverity issue: 158633
> > Fixes: a0194d82 ("net/failsafe: add flexible device definition")
> > 
> 
> The fixline should be 12-char long I think:
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
> 
> > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> 
> Otherwise:
> 
> Acked-by: Gaetan Rivet <gaetan.rivet at 6wind.com>

Applied, thanks