[dpdk-dev] [PATCH] ethdev: add notice for planned name size change

Shahaf Shuler shahafs at mellanox.com
Tue Aug 8 06:56:15 CEST 2017


Tuesday, August 8, 2017 1:20 AM, Yongseok Koh:
> > On Jul 6, 2017, at 8:07 AM, Stephen Hemminger
> <stephen at networkplumber.org> wrote:
> >
> > VMBUS support will use GUID in eth_dev_data name field which requires
> > at least 37 characters. Plan for increase in size now.
> >
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 2e708dbe0deb..d5b70c50064a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -95,3 +95,7 @@ Deprecation Notices
> >   The non-"do-sig" versions of the hash tables will be removed
> >   (including the ``signature_offset`` parameter)
> >   and the "do-sig" versions renamed accordingly.
> > +
> > +* ethdev: An ABI change is planned for 17.11 for the structure
> eth_dev_data.
> Isn't it better to use "``rte_eth_dev_data``"?
> 
> > +  The size of the unique name will increase RTE_ETH_NAME_MAX_LEN
> from
> > + 32 to
> > +  64 characters to allow using a globally unique identifier (GUID) in this
> field.
> 
> Except for the small comment above,
> Acked-by: Yongseok Koh <yskoh at mellanox.com>

Acked-by: Shahaf Shuler <shahafs at mellanox.com>

> 
> Thanks,
> Yongseok



More information about the dev mailing list