[dpdk-dev] [PATCH 0/6] remove unncessary void cast

Stephen Hemminger stephen at networkplumber.org
Wed Aug 23 17:44:39 CEST 2017


There are many places that cast away the return value from
rte_memcpy().  This was a common practice in the Unix BSD days because
lint would complain about unused return values, but it is not done
in modern Linux style because it clutters the code.

Maybe it was done for some Coverity warnings. If so, that issue
should be addressed with Coverity overrides not more code clutter.

Stephen Hemminger (6):
  testpmd: remove unnecessary void casts
  bnx2x: remove unnecssary void cast of rte_memcpy
  sfc: remove unnecessary cast of rte_memcpy
  e1000: remove unnecessary cast of rte_memcpy
  i40e: remove unnecessary cast of rte_memcpy
  ixgbe: remove unnecessary cast of rte_memcpy

 app/test-pmd/cmdline.c            | 14 +++++-----
 app/test-pmd/config.c             |  4 +--
 app/test-pmd/testpmd.c            |  2 +-
 drivers/net/bnx2x/bnx2x.c         |  6 ++---
 drivers/net/bnx2x/bnx2x.h         |  4 +--
 drivers/net/bnx2x/ecore_sp.h      |  2 +-
 drivers/net/e1000/igb_flow.c      |  8 +++---
 drivers/net/i40e/i40e_ethdev.c    | 54 +++++++++++++++++++--------------------
 drivers/net/i40e/i40e_ethdev_vf.c | 10 ++++----
 drivers/net/i40e/i40e_fdir.c      |  2 +-
 drivers/net/i40e/i40e_pf.c        |  2 +-
 drivers/net/i40e/i40e_tm.c        |  6 ++---
 drivers/net/i40e/rte_pmd_i40e.c   | 16 ++++++------
 drivers/net/ixgbe/ixgbe_ethdev.c  |  4 +--
 drivers/net/ixgbe/ixgbe_fdir.c    |  2 +-
 drivers/net/ixgbe/ixgbe_flow.c    | 20 +++++++--------
 drivers/net/ixgbe/ixgbe_tm.c      |  6 ++---
 drivers/net/sfc/sfc_ethdev.c      |  2 +-
 18 files changed, 82 insertions(+), 82 deletions(-)

-- 
2.11.0



More information about the dev mailing list