[dpdk-dev] [PATCH v2 04/14] net/avf: enable basic Rx Tx func

[Ferruh Yigit]

On 11/23/2017 10:33 PM, Jingjing Wu wrote:
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>

<...>

> @@ -31,8 +31,8 @@
>   *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */
>  
> -#ifndef _AVF_LOGS_H_
> -#define _AVF_LOGS_H_
> +#ifndef _AVF_LOG_H_
> +#define _AVF_LOG_H_

Can you please squash this one with patch 1/14 ?

<...>

> @@ -185,17 +227,13 @@ void avf_dump_tx_descriptor(const struct avf_tx_queue *txq,
>  	       tx_desc->cmd_type_offset_bsz);
>  }
>  
> -#ifdef RTE_LIBRTE_AVF_RX_DUMP
> +#ifdef DEBUG_DUMP_DESC
>  #define AVF_DUMP_RX_DESC(rxq, desc, rx_id) \
>  	avf_dump_rx_descriptor(rxq, desc, rx_id);
> -#else
> -#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) do { } while (0)
> -#endif
> -
> -#ifdef RTE_LIBRTE_AVF_TX_DUMP
>  #define AVF_DUMP_TX_DESC(txq, desc, tx_id) \
>  	avf_dump_tx_descriptor(txq, desc, tx_id);
>  #else
> +#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) do { } while (0)
>  #define AVF_DUMP_TX_DESC(txq, desc, tx_id) do { } while (0)
>  #endif

Although we are trying to add as less as compile time config, this has been
defined in Makefile with compiled out also seems not good option, what do you
think converting this into another config option?

<...>