[dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files
Hunt, David
david.hunt at intel.com
Mon Dec 11 11:44:53 CET 2017
Hi Marko,
On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic at intel.com>
> ---
> lib/librte_power/Makefile | 2 +-
> ...e_power_acpi_cpufreq.c => power_acpi_cpufreq.c} | 32 +++++++++++-----------
> ...e_power_acpi_cpufreq.h => power_acpi_cpufreq.h} | 28 +++++++++----------
> lib/librte_power/rte_power.c | 28 +++++++++----------
> 4 files changed, 45 insertions(+), 45 deletions(-)
> rename lib/librte_power/{rte_power_acpi_cpufreq.c => power_acpi_cpufreq.c} (94%)
> rename lib/librte_power/{rte_power_acpi_cpufreq.h => power_acpi_cpufreq.h} (88%)
>
> diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile
> index 1b1491d..bf5a55e 100644
> --- a/lib/librte_power/Makefile
> +++ b/lib/librte_power/Makefile
> @@ -42,7 +42,7 @@ EXPORT_MAP := rte_power_version.map
> LIBABIVER := 1
>
> # all source are stored in SRCS-y
> -SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c rte_power_acpi_cpufreq.c
> +SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
> SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c
>
> # install this header file
> diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> similarity index 94%
> rename from lib/librte_power/rte_power_acpi_cpufreq.c
> rename to lib/librte_power/power_acpi_cpufreq.c
--snip--
Could I suggest adding the following to the commit message?
"Rename private header file rte_power_acpi_cpufreq.c to
power_acpi_cpufreq.c. This prevents the private functions from leaking
into the documentation.
Change any private functions from rte_<function_name> to just
<function_name>. Reserve the rte_ for public functions. "
Regards,
Dave.
More information about the dev
mailing list