[dpdk-dev] [PATCH] net/tap: renamed netlink functions

Nicolau, Radu radu.nicolau at intel.com
Fri Dec 15 17:34:28 CET 2017



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, December 15, 2017 4:20 PM
> To: Nicolau, Radu <radu.nicolau at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>;
> pascal.mazon at 6wind.com
> Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions
> 
> On Fri, 15 Dec 2017 11:34:37 +0000
> Radu Nicolau <radu.nicolau at intel.com> wrote:
> 
> > Functions like nl_recev and nl_send name clash functions in the libnl
> > library (https://www.infradead.org/~tgr/libnl/).
> > All functions declared in tap_netlink.h were decorated with tap_ for
> > consistency.
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
> > ---
> 
> This make sense to fix, but name clash should only matter if tap PMD and
> libnl were statically linked in same application. Wouldn't that be a license
> violation.

The tap PMD is statically linked, but libnl is not, still this leads to symbol names clashing. Application that needs the functions from libnl (silently) ends up with the ones in tap PMD.


More information about the dev mailing list