[dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag

Thomas Monjalon thomas at monjalon.net
Mon Dec 18 17:30:26 CET 2017


18/12/2017 16:52, Bruce Richardson:
> On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote:
> > --- a/GNUmakefile
> > +++ b/GNUmakefile
> > @@ -1,33 +1,6 @@
> > -#   BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> >  #
> >  #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> 
> Actually, minor comment, can we remove the blank line between the SPDX
> identifier and the copyright? Given that in the majority of cases, we
> will only have one line each, having a space between them is a) probably
> unnecessary, and b) looks weird IMHO.
> 
> I'm currently working on a patchset to update the meson.build files, and
> I think having:
> 
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
> 
> looks better as a header than two one-line paragraphs.

+1, I agree with Bruce


More information about the dev mailing list