[dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

[Nelio Laranjeiro]

Hi Keith,

On Mon, Dec 18, 2017 at 06:43:35PM +0000, Wiles, Keith wrote:
> 
> 
> > On Dec 18, 2017, at 11:59 AM, Adrien Mazarguil <adrien.mazarguil at 6wind.com> wrote:
> 
> >> Not to criticize style, but a few blank lines could help in
> >> readability for these files IMHO. Unless blank lines are illegal
> >> :-)
> > 
> > It's a matter of taste, I think people tend to add random blank lines where
> > they think doing so clarifies things for themselves, resulting in
> > inconsistent coding style not much clearer for everyone after several
> > iterations.
> > 
> > As a maintainer I've grown tired of discussions related to blank lines while
> > reviewing patches. That's why except for a few special cases, I now enforce
> > exactly the bare minimum of one blank line between variable declarations and
> > the rest of the code inside each block.
> > 
> > If doing so makes a function unreadable then perhaps it needs to be split :)
> > I'm sure you'll understand!
> 
> I do not really understand the problem as I have not seen any
> complaints about blank lines unless two or more in a row. I have never
> seen someone complain about a given blank line in a function, unless a
> missing one to split up the declared variables and code in a function
> or block of code.

It is true when the amount of blank lines are few and logical, but we
generally see patch where in the same file we see random blank lines
added without any logic, generally to easily identify where the
modification are done.

> It is a shame you have decided to take the minimum approach to blank
> lines, IMO it does not make a lot of sense. I only bring it up to help
> others with reading your code like our customers.
>
> We do not have rule for this so I can not force anyone to add blank
> lines for readability, so I have to live with it. :-(

As there is no clear rules, the best one is limiting this situation to
the extreme minimal, otherwise explaining the logic behind it is very
difficult as it will differ from one maintainer to another one, it will
increase the amount of patches refused due to coding style issues.

> > Regards,
> > 
> > -- 
> > Adrien Mazarguil
> > 6WIND
> 
> Regards,
> Keith
> 

Regards,

-- 
Nélio Laranjeiro
6WIND