[dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic
Thomas Monjalon
thomas at monjalon.net
Thu Dec 28 10:05:06 CET 2017
28/12/2017 07:12, Zhiyong Yang:
> In the function rte_pci_ioport_map, if uio_pci_generic is used on X86
> platform, pci_ioport_map() is invoked, the operation
> ev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; is execused directly,
> it causes the wrong assignment for uio_pci_generic, the patch fixes it.
[...]
> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -723,7 +723,9 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused,
> if (!found)
> return -1;
>
> - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
> + if (dev->kdrv == RTE_KDRV_NONE)
> + dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
I don't understand the logic.
NONE is different of UNKNOWN.
Your are talking about uio_pci_generic. In this case, it should be
RTE_KDRV_UIO_GENERIC.
More information about the dev
mailing list