[dpdk-dev] [PATCH] app/testpmd: Fix typos

Mcnamara, John john.mcnamara at intel.com
Tue Feb 28 18:20:47 CET 2017


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nirmoy Das
> Sent: Monday, February 27, 2017 7:24 PM
> To: dev at dpdk.org
> Cc: Nirmoy Das <ndas at suse.de>
> Subject: [dpdk-dev] [PATCH] app/testpmd: Fix typos
> 
> fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c,
> app/test-pmd/testpmd.c
> 
> Signed-off-by: Nirmoy Das <ndas at suse.de>


Hi Nirmoy,

Thanks for that.

Just a small heads-up since this is your first patch. The subject line should
be lowercase (apart from known abbreviations) and there is no need to list
the files in the body since git will record that anyway. Have a look at
the contribution guidelines for some more pointers:

http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line

Apart from that, thanks for the patch.

Acked-by: John McNamara <john.mcnamara at intel.com>




More information about the dev mailing list