[dpdk-dev] [PATCH v7 04/27] net/i40e: set VF VLAN anti-spoofing from PF

[Lu, Wenzhuo]

Hi Jingjing,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, January 5, 2017 4:52 PM
> To: Lu, Wenzhuo; dev at dpdk.org
> Cc: Lu, Wenzhuo
> Subject: RE: [dpdk-dev] [PATCH v7 04/27] net/i40e: set VF VLAN anti-spoofing
> from PF
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Tuesday, January 3, 2017 2:54 PM
> > To: dev at dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> > Subject: [dpdk-dev] [PATCH v7 04/27] net/i40e: set VF VLAN
> > anti-spoofing from PF
> >
> > Support enabling/disabling VF VLAN anti-spoofing from PF.
> > User can call the API on PF to enable/disable a specific VF's VLAN anti-
> spoofing.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c            | 116
> > +++++++++++++++++++++++++++++-
> >  drivers/net/i40e/i40e_ethdev.h            |   1 +
> >  drivers/net/i40e/rte_pmd_i40e.h           |  19 +++++
> >  drivers/net/i40e/rte_pmd_i40e_version.map |   1 +
> >  4 files changed, 135 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 68c07de..bcc59b2 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -4418,6 +4418,7 @@ struct i40e_vsi *
> >  	vsi->max_macaddrs = I40E_NUM_MACADDR_MAX;
> >  	vsi->parent_vsi = uplink_vsi ? uplink_vsi : pf->main_vsi;
> >  	vsi->user_param = user_param;
> > +	vsi->vlan_anti_spoof_on = 0;
> >  	/* Allocate queues */
> >  	switch (vsi->type) {
> >  	case I40E_VSI_MAIN  :
> > @@ -5761,17 +5762,35 @@ struct i40e_vsi *
> >  			 uint16_t vlan_id, bool on)
> >  {
> >  	uint32_t vid_idx, vid_bit;
> > +	struct i40e_hw *hw = I40E_VSI_TO_HW(vsi);
> > +	struct i40e_aqc_add_remove_vlan_element_data vlan_data = {0};
> > +	int ret;
> >
> >  	if (vlan_id > ETH_VLAN_ID_MAX)
> >  		return;
> >
> >  	vid_idx = I40E_VFTA_IDX(vlan_id);
> >  	vid_bit = I40E_VFTA_BIT(vlan_id);
> > +	vlan_data.vlan_tag = rte_cpu_to_le_16(vlan_id);
> >
> > -	if (on)
> > +	if (on) {
> > +		if (vsi->vlan_anti_spoof_on) {
> > +			ret = i40e_aq_add_vlan(hw, vsi->seid,
> > +					       &vlan_data, 1, NULL);
> > +			if (ret != I40E_SUCCESS)
> > +				PMD_DRV_LOG(ERR, "Failed to add vlan
> filter");
> > +		}
> >  		vsi->vfta[vid_idx] |= vid_bit;
> > -	else
> > +	} else {
> > +		if (vsi->vlan_anti_spoof_on) {
> > +			ret = i40e_aq_remove_vlan(hw, vsi->seid,
> > +						  &vlan_data, 1, NULL);
> > +			if (ret != I40E_SUCCESS)
> > +				PMD_DRV_LOG(ERR,
> > +					    "Failed to remove vlan filter");
> > +		}
> >  		vsi->vfta[vid_idx] &= ~vid_bit;
> > +	}
> >  }
> >
> The function i40e_set_vlan_filter is used to store the vlan info in vsi structure. I
> think it will be better to move the hardware vlan filter handling to
> i40e_vsi_add_vlan who called the i40e_set_vlan_filter function to let the code
> more easy to maintain.
Thanks for the suggestion. I'll split it to 2 functions, one for storing, the other for HW setting.
> 
> 
> Thanks
> Jingjing