[dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application

Mrozowicz, SlawomirX slawomirx.mrozowicz at intel.com
Mon Jan 9 10:11:55 CET 2017



>-----Original Message-----
>From: De Lara Guarch, Pablo
>Sent: Friday, January 6, 2017 1:22 PM
>To: Mrozowicz, SlawomirX <slawomirx.mrozowicz at intel.com>;
>dev at dpdk.org
>Cc: Mrozowicz, SlawomirX <slawomirx.mrozowicz at intel.com>; Doherty,
>Declan <declan.doherty at intel.com>; Kerlin, Marcin
><marcin.kerlin at intel.com>
>Subject: RE: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for
>new performance test application
>
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Slawomir
>> Mrozowicz
>> Sent: Thursday, January 05, 2017 4:50 PM
>> To: dev at dpdk.org
>> Cc: Mrozowicz, SlawomirX; Doherty, Declan; Kerlin, Marcin
>> Subject: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for
>> new performance test application
>>
>> This patch adds helper functions for new performance application.
>> Application can be used to measute throughput and latency of
>> cryptography operation performed by crypto device.
>>
>> Signed-off-by: Declan Doherty <declan.doherty at intel.com>
>> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz at intel.com>
>> Signed-off-by: Marcin Kerlin <marcinx.kerlin at intel.com>
>
>Hi Slawomir,
>
>You should change the title of this patch to something like: "cryptodev: add
>functions for...".
>Also, maybe it would be better to say "add functions to retrieve device info",
>since you are not saying much with the current title.
>
>I have seen also that this is based on the SGL code, so this patch didn't apply
>cleanly.
>Next time, specify it in the email the dependencies of the patch.
>
>Thanks,
>Pablo
>
I am going to change the title of this patch to:
"cryptodev: add functions to retrieve device info"
Is it ok for you?

I will fix the problem with correct patch applying.

Sławomir




More information about the dev mailing list