[dpdk-dev] [PATCH 13/13] i40e: improve message grepability
Ferruh Yigit
ferruh.yigit at intel.com
Mon Jan 9 15:11:59 CET 2017
On 12/13/2016 1:08 AM, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <michal.miroslaw at atendesoftware.pl>
> ---
<...>
> if (ret)
> - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control "
> - " frames from VSIs.");
> + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control frames from VSIs.");
According latest discussion, msg integrity has priority over line
limitation.
But can you please break the lines while keeping whole msg, like:
> + PMD_INIT_LOG(ERR,
"Failed to add filter to drop flow control frames from VSIs.");
<...>
> if (ret != I40E_SUCCESS) {
> - PMD_DRV_LOG(ERR, "Fail to debug read from "
> - "I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);
> + PMD_DRV_LOG(ERR, "Fail to debug read from I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);
And can you wrap arguments into next line:
+ PMD_DRV_LOG(ERR,
"Fail to debug read from I40E_GL_SWT_L2TAGCTRL[%d]",
reg_id);
<...>
More information about the dev
mailing list