[dpdk-dev] [PATCH v3] kni: use bulk functions to allocate and free mbufs

Yuanhan Liu yuanhan.liu at linux.intel.com
Wed Jan 18 10:03:33 CET 2017

On Wed, Jan 18, 2017 at 03:51:55PM +0700, Sergey Vyazmitinov wrote:
> Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk
> functions. This can improve performance more than two times.
> Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov at brain4net.com>
> ---
> v2:
> * CSG fixes.
> v3:
> * Fixed issue with possible different mempools in buffer list.
> * Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
> processing in the kni_allocate_mbufs.


Few thing to note here:

- You should Cc all guys involved in last discussion, but not just the
  maintainers listed in the MAINTAINERS file. They gave your (valuable)
  comments, show some respect to them.

- You can't simply grab the code from Stephen and take it as yours.
  You don't even mention him anywhere in this patch.

  You should at least add something like "Suggested-by: Stephen ..."
  Or better, separate the patch into two: one to introduce bulk free
  and mark Stephen as the author, and another one to apply it to KNI.


More information about the dev mailing list