[dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver

[Akhil Goyal]

On 1/20/2017 6:02 PM, Neil Horman wrote:
> On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.goyal at nxp.com wrote:
>> From: Akhil Goyal <akhil.goyal at nxp.com>
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
>> Signed-off-by: Akhil Goyal <akhil.goyal at nxp.com>
>> ---
>>  config/common_base                                 |   8 +
>>  config/defconfig_arm64-dpaa2-linuxapp-gcc          |  12 +
>>  drivers/bus/Makefile                               |   3 +
>>  drivers/common/Makefile                            |   3 +
>>  drivers/crypto/Makefile                            |   1 +
>>  drivers/crypto/dpaa2_sec/Makefile                  |  77 +++++
>>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c        | 374 +++++++++++++++++++++
>>  drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h          |  70 ++++
>>  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h          | 225 +++++++++++++
>>  .../crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map |   4 +
>>  drivers/net/dpaa2/Makefile                         |   1 +
>>  drivers/pool/Makefile                              |   4 +
>>  mk/rte.app.mk                                      |   6 +
>>  13 files changed, 788 insertions(+)
>>  create mode 100644 drivers/crypto/dpaa2_sec/Makefile
>>  create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>>  create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h
>>  create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
>>  create mode 100644 drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map
>>
> NAK, you're trying to patch driver/bus/Makefile, which doesn't exist in the
> upstream tree, please fix your patch.
>
> I'm also opposed to the inclusion of pmds that require non-open external
> libraries as your documentation suggests that you require.  If you need an out
> of tree library to support your hardware, you will recieve no benefit from the
> upstream community in terms of testing and maintenence, nor will the community
> be able to work with your hardware on arches that your library doesn't support.
>
> Neil
>
Thanks for your comments Neil.
dpaa2_sec driver is dependent on dpaa2 driver which is in review in 
other thread. I have mentioned that in the cover letter.
Its latest version is http://dpdk.org/dev/patchwork/patch/19782/

Also there is no external library used. The libraries that are mentioned 
in the documentation are all part of the above dpaa2 driver patchset.

-Akhil