[dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage

[Ferruh Yigit]

On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/cxgbe/sge.c:900:3: warning:
> Value stored to 'in_use' is never read
>         in_use += q->size;
>         ^         ~~~~~~~
> 
> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit at gmail.com>
> ---
>  drivers/net/cxgbe/sge.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
> index fc03a0c26..42051ca01 100644
> --- a/drivers/net/cxgbe/sge.c
> +++ b/drivers/net/cxgbe/sge.c
> @@ -891,14 +891,10 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq,
>  	unsigned int flits, ndesc;
>  	unsigned char type = 0;
>  	int credits, hw_cidx = ntohs(q->stat->cidx);
> -	int in_use = q->pidx - hw_cidx + flits_to_desc(q->coalesce.flits);
>  
>  	/* use coal WR type 1 when no frags are present */
>  	type = (mbuf->nb_segs == 1) ? 1 : 0;
>  
> -	if (in_use < 0)
> -		in_use += q->size;

Intention can be "q->in_use" here. That change can be proper fix instead
of removing.

I will wait for maintainers comment to get the patch.

> -
>  	if (unlikely(type != q->coalesce.type && q->coalesce.idx))
>  		ship_tx_pkt_coalesce_wr(adap, txq);
>  
>