[dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
> Sent: Thursday, July 6, 2017 9:54 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> dev at dpdk.org
> Cc: hemant.agrawal at nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
> 
> On 7/6/2017 1:19 PM, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
> >> Sent: Wednesday, July 5, 2017 5:22 PM
> >> To: dev at dpdk.org
> >> Cc: hemant.agrawal at nxp.com; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch at intel.com>; Akhil Goyal <akhil.goyal at nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
> >>
> >> while registering driver to dpaa2, hard coded string is used.
> >> It is now updated as per the latest changes in string name.
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal at nxp.com>
> >> ---
> >>   drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> index 769a139..b0794f5 100644
> >> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> >> rte_dpaa2_sec_driver = {
> >>   	.remove = cryptodev_dpaa2_sec_remove,
> >>   };
> >>
> >> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> >> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> >> rte_dpaa2_sec_driver);
> >>   RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> >> cryptodev_driver_id);
> >> --
> >> 2.9.3
> >
> > Now that the name is internal, and since this not used to create a
> > vdev and therefore, it is not used publicly, could we modify the name
> > from "crypto_dpaa2_sec_pmd" to "crypto_dpaa2_sec", to follow the
> crypto driver name convention (crypto_<pmd_name>?
> >
> > Thanks,
> > Pablo
> >
> >
> yes no issues.

Applied to dpdk-next-crypto.
Thanks,

Pablo