[dpdk-dev] [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API

[Lu, Wenzhuo]

Hi Qi,

> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Saturday, May 27, 2017 3:53 AM
> To: Zhang, Helin; Lu, Wenzhuo
> Cc: dev at dpdk.org; Zhang, Qi Z
> Subject: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API
> 
> Enable IPv6 support with rte_flow API.
> Only support Sigature Match.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 112
> ++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 104 insertions(+), 8 deletions(-)

>  	/* Get the TCP info. */
>  	if (item->type == RTE_FLOW_ITEM_TYPE_TCP) {
>  		/**
>  		 * Set the flow type even if there's no content
>  		 * as we must have a flow type.
>  		 */
> -		rule->ixgbe_fdir.formatted.flow_type =
> +		rule->ixgbe_fdir.formatted.flow_type |=
>  			IXGBE_ATR_FLOW_TYPE_TCPV4;
This macro is misleading, better change it to IXGBE_ATR_L4TYPE_TCP.

>  		/*Not supported last point for range*/
>  		if (item->last) {
> @@ -1715,7 +1811,7 @@ ixgbe_parse_fdir_filter_normal(const struct
> rte_flow_attr *attr,
>  		 * Set the flow type even if there's no content
>  		 * as we must have a flow type.
>  		 */
> -		rule->ixgbe_fdir.formatted.flow_type =
> +		rule->ixgbe_fdir.formatted.flow_type |=
>  			IXGBE_ATR_FLOW_TYPE_UDPV4;
IXGBE_ATR_L4TYPE_UDP is better.

>  		/*Not supported last point for range*/
>  		if (item->last) {
> @@ -1775,7 +1871,7 @@ ixgbe_parse_fdir_filter_normal(const struct
> rte_flow_attr *attr,
>  		 * Set the flow type even if there's no content
>  		 * as we must have a flow type.
>  		 */
> -		rule->ixgbe_fdir.formatted.flow_type =
> +		rule->ixgbe_fdir.formatted.flow_type |=
>  			IXGBE_ATR_FLOW_TYPE_SCTPV4;
IXGBE_ATR_L4TYPE_SCTP is better.

>  		/*Not supported last point for range*/
>  		if (item->last) {
> --
> 2.7.4