[dpdk-dev] [PATCH 00/12] Remove cryptodev driver

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Jun 9 12:29:12 CEST 2017


Hi Gaetan,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Friday, June 09, 2017 11:02 AM
> To: Gaëtan Rivet
> Cc: Doherty, Declan; thomas at monjalon.net; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
> 
> 
> 
> > -----Original Message-----
> > From: Gaëtan Rivet [mailto:gaetan.rivet at 6wind.com]
> > Sent: Friday, June 09, 2017 10:58 AM
> > To: De Lara Guarch, Pablo
> > Cc: Doherty, Declan; thomas at monjalon.net; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
> >
> > On Thu, Jun 08, 2017 at 03:58:16PM +0000, De Lara Guarch, Pablo wrote:
> > > Hi Gaetan,
> > >
> > > > -----Original Message-----
> > > > From: Gaëtan Rivet [mailto:gaetan.rivet at 6wind.com]
> > > > Sent: Wednesday, June 07, 2017 11:55 PM
> > > > To: De Lara Guarch, Pablo
> > > > Cc: Doherty, Declan; thomas at monjalon.net; dev at dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
> > > >
> > > > Hi Pablo,
> > > >
> > > > On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote:
> > > > > Following the same aproach taken for ethdev, this patch series
> > > > > removes the PCI specific structure cryptodev driver from
> > rte_cryptodev.
> > > > >
> > > > > The patchset makes the following changes:
> > > > >
> > > > > - Moves the virtual and PCI device specific functions to separate
> files,
> > > > >   so other cryptodev header files contain only device type agnostic
> > > > functions.
> > > > >
> > > > > - Modifies device info retrieval function to set the driver name for all
> > > > devices
> > > > >   and set PCI info inside PCI device PMDs
> > > > >
> > > > > - Removes cryptodev driver structure from cryptodev library and
> > drivers
> > > > >   that were using it (QAT and dpaa2)
> > > > >
> > > >
> > > > While most of the work seems to be done within this patchset, there
> > are
> > > > still rte_pci.h includes in both:
> > > >
> > > > lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h>
> > > > lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h>
> > > >
> > > > This breaks the compilation when the PCI bus is compiled outside the
> > EAL.
> > > > Would you be able to remove those last dependencies?
> > >
> > > These includes have been removed already in the patchset.
> > > Have you applied all 12 patches?
> > >
> >
> > Ah yes, sorry, I must have missed a few.
> > I have some trouble applying the patch however, I will test the
> > integration with the PCI bus move after I resolve this.
> 
> It might not apply cleanly after the latest patches that got merged.
> I will send a rebased v2.

I am not sure which problem you are having. The patchset applies cleanly
on dpdk-next-crypto and dpdk.

> 
> Pablo
> 
> >
> > > Thanks,
> > > Pablo
> > >
> > >
> >
> > --
> > Gaëtan Rivet
> > 6WIND


More information about the dev mailing list