[dpdk-dev] [PATCH 38/38] net/dpaa: add packet dump for debugging

[Ferruh Yigit]

On 6/16/2017 6:41 AM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>

Is there a driver documentation, I haven't see any in net/dpaa patches?

<...>
> +CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER_DISPLAY=n
> +CONFIG_RTE_LIBRTE_DPAA_CHECKING=n

This config option is not used at all, can be removed.

<...>
> +#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
> +		DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err);

Out of curiosity, what exactly done here. Is this a special queue, what
is does? It can be useful if documented more in commit log.

> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_RX_ERROR].dpaa_intf = dpaa_intf;
> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
> +		DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err);
> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_TX_ERROR].dpaa_intf = dpaa_intf;
> +#endif
> +
<...>