[dpdk-dev] [PATCH v3 02/16] net/avp: public header files

[Chas Williams]

On Wed, 2017-03-01 at 19:19 -0500, Allain Legacy wrote:
> +
> +/**
> + * Memory aligment (cache aligned)

Spelling -- alignment.

> + */
> +#ifndef RTE_AVP_ALIGNMENT
> +#define RTE_AVP_ALIGNMENT 64
> +#endif

This is already provided by DPDK as CONFIG_RTE_CACHE_LINE_SIZE

> + * Defines the number of mbuf pools supported per device (1 per socket)
> + * @note This value should be equal to RTE_MAX_NUMA_NODES
> + */
> +#define RTE_AVP_MAX_MEMPOOLS (8)

Perhaps it should be RTE_MAX_NUMA_NODES then?

> +#define RTE_AVP_MAX_QUEUES (8) /**< Maximum number of queues per device */
> +
> +/** Maximum number of chained mbufs in a packet */
> +#define RTE_AVP_MAX_MBUF_SEGMENTS (5)

The ()'s around constants aren't really necessary.  You aren't going to
get side effects.